Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3128)

Unified Diff: chrome/installer/util/version.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/version.cc
diff --git a/chrome/installer/util/version.cc b/chrome/installer/util/version.cc
index ab9e4501ecd1a641ee0a2070fabca66bc2680ecf..7618e7dedcab8aac90d25cfbb115916ce44012a6 100644
--- a/chrome/installer/util/version.cc
+++ b/chrome/installer/util/version.cc
@@ -40,7 +40,7 @@ bool installer::Version::IsHigherThan(const installer::Version* other) const {
installer::Version* installer::Version::GetVersionFromString(
const string16& version_str) {
std::vector<string16> numbers;
- SplitString(version_str, '.', &numbers);
+ base::SplitString(version_str, '.', &numbers);
if (numbers.size() != 4) {
LOG(ERROR) << "Invalid version string: " << version_str;
« no previous file with comments | « chrome/installer/util/shell_util.cc ('k') | chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698