chrome/browser/chromeos/input_method/input_method_util.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/input_method/input_method_util.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_util.cc b/chrome/browser/chromeos/input_method/input_method_util.cc

index 188dea21fb970d844074e791d1610884b85cdd2a..0df1b45af095c8b4e2a5009c289a6da993208d8c 100644

--- a/chrome/browser/chromeos/input_method/input_method_util.cc

+++ b/chrome/browser/chromeos/input_method/input_method_util.cc

@@ -435,7 +435,7 @@ std::string GetLanguageCodeFromDescriptor(

language_code == "zh" ||

language_code == "pt")) {

std::vector<std::string> portions;

- SplitString(descriptor.id, ':', &portions);

+ base::SplitString(descriptor.id, ':', &portions);

if (portions.size() >= 2 && !portions[1].empty()) {

language_code.append("-");

language_code.append(StringToUpperASCII(portions[1]));

@@ -463,7 +463,7 @@ std::string GetKeyboardLayoutName(const std::string& input_method_id) {

}

std::vector<std::string> splitted_id;

- SplitString(input_method_id, ':', &splitted_id);

+ base::SplitString(input_method_id, ':', &splitted_id);

return (splitted_id.size() > 1) ? splitted_id[1] : "";

}

« no previous file with comments | « chrome/browser/browser_main.cc ('k') | chrome/browser/chromeos/login/authenticator.cc » ('j') | no next file with comments »