net/websockets/websocket_job_unittest.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_job_unittest.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/websockets/websocket_job_unittest.cc

diff --git a/net/websockets/websocket_job_unittest.cc b/net/websockets/websocket_job_unittest.cc

index 9fde6c9054df9170aea59c61c1cf1eede28ff122..53d4a62546fe523d5bb3f8c640636c59dde1f16e 100644

--- a/net/websockets/websocket_job_unittest.cc

+++ b/net/websockets/websocket_job_unittest.cc

@@ -328,7 +328,7 @@ TEST_F(WebSocketJobTest, SlowHandshake) {

"8jKS'y:G*Co,Wxa-";

std::vector<std::string> lines;

- SplitString(kHandshakeResponseMessage, '\n', &lines);

+ base::SplitString(kHandshakeResponseMessage, '\n', &lines);

for (size_t i = 0; i < lines.size() - 2; i++) {

std::string line = lines[i] + "\r\n";

SCOPED_TRACE("Line: " + line);

« no previous file with comments | « net/tools/hresolv/hresolv.cc ('k') | views/controls/label.cc » ('j') | no next file with comments »