chrome/browser/dom_ui/options/cookies_view_handler.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/options/cookies_view_handler.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/dom_ui/options/cookies_view_handler.cc

diff --git a/chrome/browser/dom_ui/options/cookies_view_handler.cc b/chrome/browser/dom_ui/options/cookies_view_handler.cc

index 35a131754cf455ad0cdc7b39eb75e11b3982f86c..160a8fa018bb3a6a97e8074282dc8ff22a707f77 100644

--- a/chrome/browser/dom_ui/options/cookies_view_handler.cc

+++ b/chrome/browser/dom_ui/options/cookies_view_handler.cc

@@ -370,7 +370,7 @@ void CookiesViewHandler::LoadChildren(const ListValue* args) {

CookieTreeNode* CookiesViewHandler::GetTreeNodeFromPath(

const std::string& path) {

std::vector<std::string> node_ids;

- SplitString(path, ',', &node_ids);

+ base::SplitString(path, ',', &node_ids);

CookieTreeNode* child = NULL;

CookieTreeNode* parent = cookies_tree_model_->GetRoot();

« no previous file with comments | « chrome/browser/dom_ui/new_tab_page_sync_handler.cc ('k') | chrome/browser/download/download_prefs.cc » ('j') | no next file with comments »