Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: webkit/glue/plugins/plugin_list_win.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/plugins/plugin_list_posix.cc ('k') | webkit/glue/plugins/webplugin_delegate_impl_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/plugin_list_win.cc
diff --git a/webkit/glue/plugins/plugin_list_win.cc b/webkit/glue/plugins/plugin_list_win.cc
index b5ded9ef52da0f36507417f8cebc919a32f9627d..e515e10f2cf3a0dcc4bd02e568186871cecea876 100644
--- a/webkit/glue/plugins/plugin_list_win.cc
+++ b/webkit/glue/plugins/plugin_list_win.cc
@@ -304,13 +304,13 @@ bool HaveSharedMimeType(const WebPluginInfo& plugin1,
// version is newer than a's, or false if it's equal or older.
bool IsNewerVersion(const std::wstring& a, const std::wstring& b) {
std::vector<std::wstring> a_ver, b_ver;
- SplitString(a, ',', &a_ver);
- SplitString(b, ',', &b_ver);
+ base::SplitString(a, ',', &a_ver);
+ base::SplitString(b, ',', &b_ver);
if (a_ver.size() == 1 && b_ver.size() == 1) {
a_ver.clear();
b_ver.clear();
- SplitString(a, '.', &a_ver);
- SplitString(b, '.', &b_ver);
+ base::SplitString(a, '.', &a_ver);
+ base::SplitString(b, '.', &b_ver);
}
if (a_ver.size() != b_ver.size())
return false;
@@ -371,7 +371,7 @@ bool PluginList::ShouldLoadPlugin(const WebPluginInfo& info,
// and don't depend on XPCOM.
if (filename == kJavaPlugin1 || filename == kJavaPlugin2) {
std::vector<std::wstring> ver;
- SplitString(info.version, '.', &ver);
+ base::SplitString(info.version, '.', &ver);
int major, minor, update;
if (ver.size() == 4 &&
base::StringToInt(ver[0], &major) &&
« no previous file with comments | « webkit/glue/plugins/plugin_list_posix.cc ('k') | webkit/glue/plugins/webplugin_delegate_impl_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698