Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: chrome_frame/metrics_service.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome_frame/chrome_frame_npapi.cc ('k') | net/base/host_mapping_rules.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 //------------------------------------------------------------------------------ 6 //------------------------------------------------------------------------------
7 // Description of the life cycle of a instance of MetricsService. 7 // Description of the life cycle of a instance of MetricsService.
8 // 8 //
9 // OVERVIEW 9 // OVERVIEW
10 // 10 //
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 this, net_log_.get(), io_loop_); 161 this, net_log_.get(), io_loop_);
162 DCHECK(proxy_service_); 162 DCHECK(proxy_service_);
163 163
164 ssl_config_service_ = new net::SSLConfigServiceDefaults; 164 ssl_config_service_ = new net::SSLConfigServiceDefaults;
165 165
166 url_security_manager_.reset( 166 url_security_manager_.reset(
167 net::URLSecurityManager::Create(NULL, NULL)); 167 net::URLSecurityManager::Create(NULL, NULL));
168 168
169 std::string csv_auth_schemes = "basic,digest,ntlm,negotiate"; 169 std::string csv_auth_schemes = "basic,digest,ntlm,negotiate";
170 std::vector<std::string> supported_schemes; 170 std::vector<std::string> supported_schemes;
171 SplitString(csv_auth_schemes, ',', &supported_schemes); 171 base::SplitString(csv_auth_schemes, ',', &supported_schemes);
172 172
173 http_auth_handler_factory_ = net::HttpAuthHandlerRegistryFactory::Create( 173 http_auth_handler_factory_ = net::HttpAuthHandlerRegistryFactory::Create(
174 supported_schemes, url_security_manager_.get(), host_resolver_, false, 174 supported_schemes, url_security_manager_.get(), host_resolver_, false,
175 false); 175 false);
176 176
177 http_transaction_factory_ = new net::HttpCache( 177 http_transaction_factory_ = new net::HttpCache(
178 net::HttpNetworkLayer::CreateFactory(host_resolver_, 178 net::HttpNetworkLayer::CreateFactory(host_resolver_,
179 NULL /* dnsrr_resovler */, 179 NULL /* dnsrr_resovler */,
180 proxy_service_, 180 proxy_service_,
181 ssl_config_service_, 181 ssl_config_service_,
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 version += "-F"; 599 version += "-F";
600 if (!version_info.IsOfficialBuild()) 600 if (!version_info.IsOfficialBuild())
601 version.append("-devel"); 601 version.append("-devel");
602 return version; 602 return version;
603 } else { 603 } else {
604 NOTREACHED() << "Unable to retrieve version string."; 604 NOTREACHED() << "Unable to retrieve version string.";
605 } 605 }
606 606
607 return std::string(); 607 return std::string();
608 } 608 }
OLDNEW
« no previous file with comments | « chrome_frame/chrome_frame_npapi.cc ('k') | net/base/host_mapping_rules.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698