chrome/browser/webdata/web_database.cc - Issue 3750001: base: Move SplitString functions into the base namespace and update the callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/webdata/web_database.cc

Issue 3750001: base: Move SplitString functions into the base namespace and update the callers. (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: brett review, reverted changes in o3d due to it's using an old base revision Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/webdata/web_database.cc

diff --git a/chrome/browser/webdata/web_database.cc b/chrome/browser/webdata/web_database.cc

index 6909e36a5016e2bae0833b9a4c7381341f686e84..26b05c55b80ba598d5572f3ae79b7f85c067d8d3 100644

--- a/chrome/browser/webdata/web_database.cc

+++ b/chrome/browser/webdata/web_database.cc

@@ -915,7 +915,7 @@ bool WebDatabase::GetKeywords(std::vector<TemplateURL*>* urls) {

template_url->set_usage_count(s.ColumnInt(8));

std::vector<std::string> encodings;

- SplitString(s.ColumnString(9), ';', &encodings);

+ base::SplitString(s.ColumnString(9), ';', &encodings);

template_url->set_input_encodings(encodings);

template_url->set_show_in_default_list(s.ColumnInt(10) == 1);

« no previous file with comments | « chrome/browser/views/shell_dialogs_win.cc ('k') | chrome/common/extensions/url_pattern.cc » ('j') | no next file with comments »