Get rid of the rest of CreateStringValue

Get rid of the rest of CreateStringValue

BUG=160586
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284201

[Evan Stade, 2014-07-11 21:00:32]

looks like a lot, but the test changes are all completely mechanical. The
non-test changes are fairly mechanical. No behavior change is intended.

stevenjb:
  chromeos/dbus/*
  chromeos/network/*
benwells:
  *extension*
sky:
  athena/virtual_keyboard/virtual_keyboard_bindings_impl.cc
  chrome/browser/* (except extensions)
  chrome/renderer/chrome_content_renderer_client_unittest.cc
  chrome/test/chromedriver/alert_commands.cc
thakis:
  base/values.cc
  base/values.h
nduca:
  cc/resources/tile_priority.cc
  content/browser/tracing/etw_system_event_consumer_win.cc
battre:
  components/pref_registry/pref_registry_syncable.cc
  components/url_matcher/url_matcher_factory_unittest.cc
pneubeck:
  chromeos/network/network_configuration_handler_unittest.cc
  chromeos/network/onc/onc_translator_onc_to_shill.cc
  chromeos/network/onc/onc_translator_shill_to_onc.cc
  chromeos/network/shill_property_handler_unittest.cc
  components/policy/*
blundell:
  components/metrics/persisted_logs.cc
  components/search_engines/default_search_policy_handler.cc
  components/search_engines/default_search_policy_handler_unittest.cc

[stevenjb, 2014-07-11 21:16:09]

chromeos/ lgtm

[sky, 2014-07-11 22:54:48]

My files LGTM

https://codereview.chromium.org/388963002/diff/20001/chrome/browser/policy/cl...
File chrome/browser/policy/cloud/cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/388963002/diff/20001/chrome/browser/policy/cl...
chrome/browser/policy/cloud/cloud_policy_browsertest.cc:141:
policy_map->Set(key::kChromeOsMultiProfileUserBehavior,
nit: I tend to think imposing your favorite style when doing changes like this
add more noise and result in inconsistent style in the file (for example,
150-153 are in the !estade style).

[sky, 2014-07-11 22:54:51]

My files LGTM

[Evan Stade, 2014-07-11 22:56:27]

https://codereview.chromium.org/388963002/diff/20001/chrome/browser/policy/cl...
File chrome/browser/policy/cloud/cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/388963002/diff/20001/chrome/browser/policy/cl...
chrome/browser/policy/cloud/cloud_policy_browsertest.cc:141:
policy_map->Set(key::kChromeOsMultiProfileUserBehavior,
On 2014/07/11 22:54:47, sky wrote:
> nit: I tend to think imposing your favorite style when doing changes like this
> add more noise and result in inconsistent style in the file (for example,
> 150-153 are in the !estade style).

I actually just ran the file (and all files in this CL) through git-cl format,
which only updates the lines you've changed.

[sky, 2014-07-11 22:58:40]

On Fri, Jul 11, 2014 at 3:56 PM, <estade@chromium.org> wrote:

>
> https://codereview.chromium.org/388963002/diff/20001/
> chrome/browser/policy/cloud/cloud_policy_browsertest.cc
> File chrome/browser/policy/cloud/cloud_policy_browsertest.cc (right):
>
> https://codereview.chromium.org/388963002/diff/20001/
> chrome/browser/policy/cloud/cloud_policy_browsertest.cc#newcode141
> chrome/browser/policy/cloud/cloud_policy_browsertest.cc:141:
> policy_map->Set(key::kChromeOsMultiProfileUserBehavior,
> On 2014/07/11 22:54:47, sky wrote:
>
>> nit: I tend to think imposing your favorite style when doing changes
>>
> like this
>
>> add more noise and result in inconsistent style in the file (for
>>
> example,
>
>> 150-153 are in the !estade style).
>>
>
> I actually just ran the file (and all files in this CL) through git-cl
> format, which only updates the lines you've changed.
>

Ah, ok. I'm totally ok with moving to a standard enforced by tools.

  -Scott


>
> https://codereview.chromium.org/388963002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[pneubeck (no reviews), 2014-07-14 07:17:58]

chromeos/network/network_configuration_handler_unittest.cc
  chromeos/network/onc/onc_translator_onc_to_shill.cc
  chromeos/network/onc/onc_translator_shill_to_onc.cc
  chromeos/network/shill_property_handler_unittest.cc
  components/policy/*

my part lgtm

[battre, 2014-07-14 07:23:03]

LGTM @
  components/pref_registry/pref_registry_syncable.cc
  components/url_matcher/url_matcher_factory_unittest.cc

[Evan Stade, 2014-07-14 21:58:54]

ping benwells, thakis, nduca, blundell

[nduca, 2014-07-14 23:10:35]

lgtm

[nduca, 2014-07-14 23:11:11]

lgtm

[Evan Stade, 2014-07-14 23:50:33]

reverted changes to base/ for now, so -thakis

[blundell, 2014-07-15 06:05:35]

//components/metrics and //components/search_engines LGTM

[Evan Stade, 2014-07-15 19:30:38]

+koz for *extension*

[Evan Stade, 2014-07-16 21:00:56]

-benwells, koz
+kalman for *extensions*

[not at google - send to devlin, 2014-07-16 21:04:50]

lgtm

[Evan Stade, 2014-07-16 21:06:23]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-16 21:10:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/388963002/60001

[Evan Stade, 2014-07-16 21:49:36]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-16 21:53:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/388963002/80001

[commit-bot: I haz the power, 2014-07-17 01:34:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-17 01:38:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 01:38:24]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Evan Stade, 2014-07-17 03:07:53]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-17 03:09:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/388963002/100001

[commit-bot: I haz the power, 2014-07-17 08:05:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 08:05:35]

Failed to apply patch for chrome/browser/policy/policy_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/policy/policy_browsertest.cc
  Hunk #1 succeeded at 753 (offset 2 lines).
  Hunk #2 succeeded at 904 with fuzz 2 (offset 11 lines).
  Hunk #3 succeeded at 1106 with fuzz 2 (offset 20 lines).
  Hunk #4 succeeded at 1272 (offset 32 lines).
  Hunk #5 succeeded at 1299 (offset 32 lines).
  Hunk #6 succeeded at 1311 (offset 32 lines).
  Hunk #7 succeeded at 1339 (offset 32 lines).
  Hunk #8 succeeded at 1500 (offset 41 lines).
  Hunk #9 succeeded at 1519 (offset 41 lines).
  Hunk #10 succeeded at 1550 (offset 41 lines).
  Hunk #11 succeeded at 1572 (offset 41 lines).
  Hunk #12 succeeded at 1608 (offset 41 lines).
  Hunk #13 succeeded at 1818 (offset 41 lines).
  Hunk #14 succeeded at 2049 (offset 65 lines).
  Hunk #15 succeeded at 2062 (offset 65 lines).
  Hunk #16 succeeded at 2099 (offset 65 lines).
  Hunk #17 succeeded at 2122 (offset 65 lines).
  Hunk #18 succeeded at 2134 (offset 65 lines).
  Hunk #19 FAILED at 2562.
  Hunk #20 succeeded at 2678 (offset 87 lines).
  Hunk #21 FAILED at 2687.
  Hunk #22 succeeded at 3056 (offset 94 lines).
  Hunk #23 succeeded at 3081 (offset 94 lines).
  Hunk #24 succeeded at 3096 (offset 94 lines).
  Hunk #25 succeeded at 3111 (offset 94 lines).
  2 out of 25 hunks FAILED -- saving rejects to file
chrome/browser/policy/policy_browsertest.cc.rej

Patch:       chrome/browser/policy/policy_browsertest.cc
Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc
b/chrome/browser/policy/policy_browsertest.cc
index
f1471600aa010ff7a25397186f500e332611ff4b..637dd68191e9429cb1abfa65f864f55ca777d8f7
100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -751,9 +751,11 @@ class LocalePolicyTest : public PolicyTest {
   virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
     PolicyTest::SetUpInProcessBrowserTestFixture();
     PolicyMap policies;
-    policies.Set(
-        key::kApplicationLocaleValue, POLICY_LEVEL_MANDATORY,
POLICY_SCOPE_USER,
-        base::Value::CreateStringValue("fr"), NULL);
+    policies.Set(key::kApplicationLocaleValue,
+                 POLICY_LEVEL_MANDATORY,
+                 POLICY_SCOPE_USER,
+                 new base::StringValue("fr"),
+                 NULL);
     provider_.UpdateChromePolicy(policies);
     // The "en-US" ResourceBundle is always loaded before this step for tests,
     // but in this test we want the browser to load the bundle as it
@@ -891,31 +893,39 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DefaultSearchProvider)
{
   policies.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true), NULL);
   policies.Set(key::kDefaultSearchProviderKeyword,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kKeyword), NULL);
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kKeyword),
+               NULL);
   policies.Set(key::kDefaultSearchProviderSearchURL,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kSearchURL), NULL);
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kSearchURL),
+               NULL);
   base::ListValue* alternate_urls = new base::ListValue();
   alternate_urls->AppendString(kAlternateURL0);
   alternate_urls->AppendString(kAlternateURL1);
   policies.Set(key::kDefaultSearchProviderAlternateURLs,
POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, alternate_urls, NULL);
   policies.Set(key::kDefaultSearchProviderSearchTermsReplacementKey,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kSearchTermsReplacementKey),
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kSearchTermsReplacementKey),
                NULL);
   policies.Set(key::kDefaultSearchProviderImageURL,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kImageURL),
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kImageURL),
                NULL);
   policies.Set(key::kDefaultSearchProviderImageURLPostParams,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kImageURLPostParams),
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kImageURLPostParams),
                NULL);
   policies.Set(key::kDefaultSearchProviderNewTabURL,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kNewTabURL),
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kNewTabURL),
                NULL);
   UpdateProviderPolicy(policies);
   default_search = service->GetDefaultSearchProvider();
@@ -1076,22 +1086,29 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, ReplaceSearchTerms) {
   policies.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true), NULL);
   policies.Set(key::kDefaultSearchProviderKeyword,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kKeyword), NULL);
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kKeyword),
+               NULL);
   policies.Set(key::kDefaultSearchProviderSearchURL,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kSearchURL), NULL);
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kSearchURL),
+               NULL);
   policies.Set(key::kDefaultSearchProviderInstantURL,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kInstantURL), NULL);
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kInstantURL),
+               NULL);
   base::ListValue* alternate_urls = new base::ListValue();
   alternate_urls->AppendString(kAlternateURL0);
   alternate_urls->AppendString(kAlternateURL1);
   policies.Set(key::kDefaultSearchProviderAlternateURLs,
POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, alternate_urls, NULL);
   policies.Set(key::kDefaultSearchProviderSearchTermsReplacementKey,
-               POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(kSearchTermsReplacementKey),
+               POLICY_LEVEL_MANDATORY,
+               POLICY_SCOPE_USER,
+               new base::StringValue(kSearchTermsReplacementKey),
                NULL);
   UpdateProviderPolicy(policies);
   default_search = service->GetDefaultSearchProvider();
@@ -1223,7 +1240,7 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DisabledPlugins) {
 
   // Now disable it with a policy.
   base::ListValue disabled_plugins;
-  disabled_plugins.Append(base::Value::CreateStringValue("*Flash*"));
+  disabled_plugins.Append(new base::StringValue("*Flash*"));
   PolicyMap policies;
   policies.Set(key::kDisabledPlugins, POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, disabled_plugins.DeepCopy(), NULL);
@@ -1250,7 +1267,7 @@ IN_PROC_BROWSER_TEST_F(PolicyTest,
DisabledPluginsExceptions) {
 
   // Disable all plugins.
   base::ListValue disabled_plugins;
-  disabled_plugins.Append(base::Value::CreateStringValue("*"));
+  disabled_plugins.Append(new base::StringValue("*"));
   PolicyMap policies;
   policies.Set(key::kDisabledPlugins, POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, disabled_plugins.DeepCopy(), NULL);
@@ -1262,8 +1279,7 @@ IN_PROC_BROWSER_TEST_F(PolicyTest,
DisabledPluginsExceptions) {
 
   // Now open an exception for flash.
   base::ListValue disabled_plugins_exceptions;
-  disabled_plugins_exceptions.Append(
-      base::Value::CreateStringValue("*Flash*"));
+  disabled_plugins_exceptions.Append(new base::StringValue("*Flash*"));
   policies.Set(key::kDisabledPluginsExceptions, POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, disabled_plugins_exceptions.DeepCopy(),
NULL);
   UpdateProviderPolicy(policies);
@@ -1291,7 +1307,7 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, EnabledPlugins) {
   EXPECT_TRUE(SetPluginEnabled(plugin_prefs, flash, false));
   EXPECT_FALSE(plugin_prefs->IsPluginEnabled(*flash));
   base::ListValue plugin_list;
- 
plugin_list.Append(base::Value::CreateStringValue(content::kFlashPluginName));
+  plugin_list.Append(new base::StringValue(content::kFlashPluginName));
   PolicyMap policies;
   policies.Set(key::kEnabledPlugins, POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER, plugin_list.DeepCopy(), NULL);
@@ -1443,9 +1459,11 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DownloadDirectory) {
   base::ScopedTempDir forced_dir;
   ASSERT_TRUE(forced_dir.CreateUniqueTempDir());
   PolicyMap policies;
-  policies.Set(key::kDownloadDirectory, POLICY_LEVEL_MANDATORY,
+  policies.Set(key::kDownloadDirectory,
+               POLICY_LEVEL_MANDATORY,
                POLICY_SCOPE_USER,
-               base::Value::CreateStringValue(forced_dir.path().value()),
NULL);
+               new base::StringValue(forced_dir.path().value()),
+               NULL);
   UpdateProviderPolicy(policies);
   DownloadAndVerifyFile(browser(), forced_dir.path(), file);
   // Verify that the first download location wasn't affected.
@@ -1460,7 +1478,7 @@ IN_PROC_BROWSER_TEST_F(PolicyTest,
   ASSERT_FALSE(service->GetExtensio…
(message too large)

[Evan Stade, 2014-07-17 16:35:42]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-17 16:38:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/388963002/120001

[commit-bot: I haz the power, 2014-07-17 17:55:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29799)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/34213)

[commit-bot: I haz the power, 2014-07-17 18:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 18:14:40]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[Evan Stade, 2014-07-18 18:30:25]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-18 18:31:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/388963002/140001

[commit-bot: I haz the power, 2014-07-18 21:25:51]

Change committed as 284201

[patrickalthoff55, 2015-01-09 12:02:03]

On 2014/07/18 21:25:51, I haz the power (commit-bot) wrote:
> Change committed as 284201