chromeos/network/onc/onc_translator_onc_to_shill.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translator_onc_to_shill.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translator_onc_to_shill.cc

diff --git a/chromeos/network/onc/onc_translator_onc_to_shill.cc b/chromeos/network/onc/onc_translator_onc_to_shill.cc

index f6b0117f694b5720775386516995dd8b2b5060b6..2fd411fa5113c304315d94fd8d28a70ef950d19b 100644

--- a/chromeos/network/onc/onc_translator_onc_to_shill.cc

+++ b/chromeos/network/onc/onc_translator_onc_to_shill.cc

@@ -31,7 +31,7 @@ scoped_ptr<base::StringValue> ConvertValueToString(const base::Value& value) {

std::string str;

if (!value.GetAsString(&str))

base::JSONWriter::Write(&value, &str);

- return make_scoped_ptr(base::Value::CreateStringValue(str));

+ return make_scoped_ptr(new base::StringValue(str));

}

// This class is responsible to translate the local fields of the given