tools/json_schema_compiler/test/any_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/any_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/any_unittest.cc

diff --git a/tools/json_schema_compiler/test/any_unittest.cc b/tools/json_schema_compiler/test/any_unittest.cc

index 039bd154bd52ae7a74020a4338601e1b6fb67f7f..d10a3eb4ef486c1881933103600602094dceb08a 100644

--- a/tools/json_schema_compiler/test/any_unittest.cc

+++ b/tools/json_schema_compiler/test/any_unittest.cc

@@ -38,7 +38,7 @@ TEST(JsonSchemaCompilerAnyTest, OptionalAnyParamsCreate) {

}

{

scoped_ptr<base::ListValue> params_value(new base::ListValue());

- scoped_ptr<base::Value> param(base::Value::CreateStringValue("asdf"));

+ scoped_ptr<base::Value> param(new base::StringValue("asdf"));

params_value->Append(param->DeepCopy());

scoped_ptr<OptionalAny::Params> params(

OptionalAny::Params::Create(*params_value));