Get rid of the rest of CreateStringValue

extensions/browser/value_store/value_store_change_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/values.h"
 #include "extensions/browser/value_store/value_store_change.h"
 #include "extensions/common/value_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::DictionaryValue;
 using base::Value;
 using extensions::DictionaryBuilder;
 using extensions::ListBuilder;
 
 namespace {
 
 TEST(ValueStoreChangeTest, NullOldValue) {
-  ValueStoreChange change("key", NULL, base::Value::CreateStringValue("value"));
+  ValueStoreChange change("key", NULL, new base::StringValue("value"));
 
   EXPECT_EQ("key", change.key());
   EXPECT_EQ(NULL, change.old_value());
   {
-    scoped_ptr<base::Value> expected(base::Value::CreateStringValue("value"));
+    scoped_ptr<base::Value> expected(new base::StringValue("value"));
     EXPECT_TRUE(change.new_value()->Equals(expected.get()));
   }
 }
 
 TEST(ValueStoreChangeTest, NullNewValue) {
-  ValueStoreChange change("key", base::Value::CreateStringValue("value"), NULL);
+  ValueStoreChange change("key", new base::StringValue("value"), NULL);
 
   EXPECT_EQ("key", change.key());
   {
-    scoped_ptr<base::Value> expected(base::Value::CreateStringValue("value"));
+    scoped_ptr<base::Value> expected(new base::StringValue("value"));
     EXPECT_TRUE(change.old_value()->Equals(expected.get()));
   }
   EXPECT_EQ(NULL, change.new_value());
 }
 
 TEST(ValueStoreChangeTest, NonNullValues) {
   ValueStoreChange change("key",
-                          base::Value::CreateStringValue("old_value"),
-                          base::Value::CreateStringValue("new_value"));
+                          new base::StringValue("old_value"),
+                          new base::StringValue("new_value"));
 
   EXPECT_EQ("key", change.key());
   {
-    scoped_ptr<base::Value> expected(
-        base::Value::CreateStringValue("old_value"));
+    scoped_ptr<base::Value> expected(new base::StringValue("old_value"));
     EXPECT_TRUE(change.old_value()->Equals(expected.get()));
   }
   {
-    scoped_ptr<base::Value> expected(
-        base::Value::CreateStringValue("new_value"));
+    scoped_ptr<base::Value> expected(new base::StringValue("new_value"));
     EXPECT_TRUE(change.new_value()->Equals(expected.get()));
   }
 }
 
 TEST(ValueStoreChangeTest, ToJson) {
   // Create a mildly complicated structure that has dots in it.
   scoped_ptr<base::DictionaryValue> value = DictionaryBuilder()
       .Set("key", "value")
       .Set("key.with.dots", "value.with.dots")
       .Set("tricked", DictionaryBuilder()
@@ skipping 21 matching lines @@
           .Set("newValue", v2))
       .Set("key.with.dots", DictionaryBuilder()
           .Set("oldValue", v3)
           .Set("newValue", v4))
       .Build();
 
   EXPECT_TRUE(from_json->Equals(expected_from_json.get()));
 }
 
 }  // namespace