extensions/browser/value_store/value_store_frontend_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/value_store/value_store_frontend_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/value_store/value_store_frontend_unittest.cc

diff --git a/extensions/browser/value_store/value_store_frontend_unittest.cc b/extensions/browser/value_store/value_store_frontend_unittest.cc

index 3d81a1d8fb65a010c051bdd1dad88356b90a6ff9..82c24cede1f3849f079669d7a424abf797318160 100644

--- a/extensions/browser/value_store/value_store_frontend_unittest.cc

+++ b/extensions/browser/value_store/value_store_frontend_unittest.cc

@@ -88,8 +88,7 @@ TEST_F(ValueStoreFrontendTest, GetExistingData) {

TEST_F(ValueStoreFrontendTest, ChangesPersistAfterReload) {

storage_->Set("key0",

scoped_ptr<base::Value>(base::Value::CreateIntegerValue(0)));

- storage_->Set("key1",

- scoped_ptr<base::Value>(base::Value::CreateStringValue("new1")));

+ storage_->Set("key1", scoped_ptr<base::Value>(new base::StringValue("new1")));

storage_->Remove("key2");

// Reload the DB and test our changes.