Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/sync/test/integration/multiple_client_preferences_sync_test.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/stringprintf.h" 5 #include "base/strings/stringprintf.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "chrome/browser/sync/test/integration/preferences_helper.h" 7 #include "chrome/browser/sync/test/integration/preferences_helper.h"
8 #include "chrome/browser/sync/test/integration/sync_test.h" 8 #include "chrome/browser/sync/test/integration/sync_test.h"
9 #include "chrome/common/pref_names.h" 9 #include "chrome/common/pref_names.h"
10 10
(...skipping 12 matching lines...) Expand all
23 private: 23 private:
24 DISALLOW_COPY_AND_ASSIGN(MultipleClientPreferencesSyncTest); 24 DISALLOW_COPY_AND_ASSIGN(MultipleClientPreferencesSyncTest);
25 }; 25 };
26 26
27 IN_PROC_BROWSER_TEST_F(MultipleClientPreferencesSyncTest, Sanity) { 27 IN_PROC_BROWSER_TEST_F(MultipleClientPreferencesSyncTest, Sanity) {
28 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 28 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
29 DisableVerifier(); 29 DisableVerifier();
30 30
31 for (int i = 0; i < num_clients(); ++i) { 31 for (int i = 0; i < num_clients(); ++i) {
32 base::ListValue urls; 32 base::ListValue urls;
33 urls.Append(base::Value::CreateStringValue( 33 urls.Append(new base::StringValue(
34 base::StringPrintf("http://www.google.com/%d", i))); 34 base::StringPrintf("http://www.google.com/%d", i)));
35 ChangeListPref(i, prefs::kURLsToRestoreOnStartup, urls); 35 ChangeListPref(i, prefs::kURLsToRestoreOnStartup, urls);
36 } 36 }
37 37
38 ASSERT_TRUE(AwaitListPrefMatches(prefs::kURLsToRestoreOnStartup)); 38 ASSERT_TRUE(AwaitListPrefMatches(prefs::kURLsToRestoreOnStartup));
39 } 39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698