tools/json_schema_compiler/test/functions_on_types_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/functions_on_types_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/functions_on_types_unittest.cc

diff --git a/tools/json_schema_compiler/test/functions_on_types_unittest.cc b/tools/json_schema_compiler/test/functions_on_types_unittest.cc

index f2f3f1b59b1d44d4887a8945542e38be3dda0bdc..86ce492012929783e14c17bea0716773a2ce4a7c 100644

--- a/tools/json_schema_compiler/test/functions_on_types_unittest.cc

+++ b/tools/json_schema_compiler/test/functions_on_types_unittest.cc

@@ -25,7 +25,7 @@ TEST(JsonSchemaCompilerFunctionsOnTypesTest, StorageAreaGetParamsCreate) {

}

{

scoped_ptr<base::ListValue> params_value(new base::ListValue());

- params_value->Append(base::Value::CreateStringValue("test"));

+ params_value->Append(new base::StringValue("test"));

scoped_ptr<StorageArea::Get::Params> params(

StorageArea::Get::Params::Create(*params_value));

ASSERT_TRUE(params);