Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: chrome/browser/prefs/session_startup_pref_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/session_startup_pref_unittest.cc
diff --git a/chrome/browser/prefs/session_startup_pref_unittest.cc b/chrome/browser/prefs/session_startup_pref_unittest.cc
index 659b4926e91845966eda734dc26dffc8bd056402..c43a67f873fc2338989ca896e17c39cd18de6e16 100644
--- a/chrome/browser/prefs/session_startup_pref_unittest.cc
+++ b/chrome/browser/prefs/session_startup_pref_unittest.cc
@@ -49,8 +49,8 @@ class SessionStartupPrefTest : public testing::Test {
TEST_F(SessionStartupPrefTest, URLListIsFixedUp) {
base::ListValue* url_pref_list = new base::ListValue;
- url_pref_list->Set(0, base::Value::CreateStringValue("google.com"));
- url_pref_list->Set(1, base::Value::CreateStringValue("chromium.org"));
+ url_pref_list->Set(0, new base::StringValue("google.com"));
+ url_pref_list->Set(1, new base::StringValue("chromium.org"));
pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list);
SessionStartupPref result =
@@ -62,13 +62,13 @@ TEST_F(SessionStartupPrefTest, URLListIsFixedUp) {
TEST_F(SessionStartupPrefTest, URLListManagedOverridesUser) {
base::ListValue* url_pref_list1 = new base::ListValue;
- url_pref_list1->Set(0, base::Value::CreateStringValue("chromium.org"));
+ url_pref_list1->Set(0, new base::StringValue("chromium.org"));
pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list1);
base::ListValue* url_pref_list2 = new base::ListValue;
- url_pref_list2->Set(0, base::Value::CreateStringValue("chromium.org"));
- url_pref_list2->Set(1, base::Value::CreateStringValue("chromium.org"));
- url_pref_list2->Set(2, base::Value::CreateStringValue("chromium.org"));
+ url_pref_list2->Set(0, new base::StringValue("chromium.org"));
+ url_pref_list2->Set(1, new base::StringValue("chromium.org"));
+ url_pref_list2->Set(2, new base::StringValue("chromium.org"));
pref_service_->SetManagedPref(prefs::kURLsToRestoreOnStartup,
url_pref_list2);

Powered by Google App Engine
This is Rietveld 408576698