chrome/browser/extensions/extension_gcm_app_handler_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

diff --git a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

index ca12a24d80b57664038e4aa95a8b0c06ba11b8c2..76c3662e310b5f7812ab0fdf26a8e696b6012ed8 100644

--- a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

+++ b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

@@ -269,7 +269,7 @@ class ExtensionGCMAppHandlerTest : public testing::Test {

manifest.SetString(manifest_keys::kVersion, "1.0.0.0");

manifest.SetString(manifest_keys::kName, kTestExtensionName);

base::ListValue* permission_list = new base::ListValue;

- permission_list->Append(base::Value::CreateStringValue("gcm"));

+ permission_list->Append(new base::StringValue("gcm"));

manifest.Set(manifest_keys::kPermissions, permission_list);

std::string error;