extensions/common/event_filter_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/event_filter_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/event_filter_unittest.cc

diff --git a/extensions/common/event_filter_unittest.cc b/extensions/common/event_filter_unittest.cc

index 0b1bd7b72ca59cad3ba11ce5c8d3a536032cdd3d..0ae063cbc5363c5e1e5b0d68f7150ee4c10f0733 100644

--- a/extensions/common/event_filter_unittest.cc

+++ b/extensions/common/event_filter_unittest.cc

@@ -30,7 +30,7 @@ class EventFilterUnittest : public testing::Test {

protected:

scoped_ptr<base::Value> HostSuffixDict(const std::string& host_suffix) {

scoped_ptr<base::DictionaryValue> dict(new DictionaryValue());

- dict->Set("hostSuffix", base::Value::CreateStringValue(host_suffix));

+ dict->Set("hostSuffix", new base::StringValue(host_suffix));

return scoped_ptr<base::Value>(dict.release());

}