Get rid of the rest of CreateStringValue

tools/json_schema_compiler/test/arrays_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/json_schema_compiler/test/arrays.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/json_schema_compiler/test/enums.h"
 
 using namespace test::api::arrays;
 
 namespace {
 
 // TODO(calamity): Change to AppendString etc once kalman's patch goes through
 static scoped_ptr<base::DictionaryValue> CreateBasicArrayTypeDictionary() {
   base::DictionaryValue* value = new base::DictionaryValue();
   base::ListValue* strings_value = new base::ListValue();
-  strings_value->Append(base::Value::CreateStringValue("a"));
-  strings_value->Append(base::Value::CreateStringValue("b"));
-  strings_value->Append(base::Value::CreateStringValue("c"));
-  strings_value->Append(base::Value::CreateStringValue("it's easy as"));
+  strings_value->Append(new base::StringValue("a"));
+  strings_value->Append(new base::StringValue("b"));
+  strings_value->Append(new base::StringValue("c"));
+  strings_value->Append(new base::StringValue("it's easy as"));
   base::ListValue* integers_value = new base::ListValue();
   integers_value->Append(new base::FundamentalValue(1));
   integers_value->Append(new base::FundamentalValue(2));
   integers_value->Append(new base::FundamentalValue(3));
   base::ListValue* booleans_value = new base::ListValue();
   booleans_value->Append(new base::FundamentalValue(false));
   booleans_value->Append(new base::FundamentalValue(true));
   base::ListValue* numbers_value = new base::ListValue();
   numbers_value->Append(base::Value::CreateDoubleValue(6.1));
   value->Set("numbers", numbers_value);
@@ skipping 146 matching lines @@
     base::DictionaryValue value;
     value.Set("types", types.release());
 
     OptionalEnumArrayType enum_array_type;
     ASSERT_TRUE(OptionalEnumArrayType::Populate(value, &enum_array_type));
     EXPECT_EQ(enums, *enum_array_type.types);
   }
   {
     base::DictionaryValue value;
     scoped_ptr<base::ListValue> enum_array(new base::ListValue());
-    enum_array->Append(base::Value::CreateStringValue("invalid"));
+    enum_array->Append(new base::StringValue("invalid"));
 
     value.Set("types", enum_array.release());
     OptionalEnumArrayType enum_array_type;
     ASSERT_FALSE(OptionalEnumArrayType::Populate(value, &enum_array_type));
     EXPECT_TRUE(enum_array_type.types->empty());
   }
 }
 
 TEST(JsonSchemaCompilerArrayTest, RefArrayType) {
   {
@@ skipping 34 matching lines @@
   ASSERT_EQ(3u, params->nums.size());
   EXPECT_EQ(2, params->nums[0]);
   EXPECT_EQ(4, params->nums[1]);
   EXPECT_EQ(8, params->nums[2]);
 }
 
 TEST(JsonSchemaCompilerArrayTest, AnyArrayParamsCreate) {
   scoped_ptr<base::ListValue> params_value(new base::ListValue());
   scoped_ptr<base::ListValue> any_array(new base::ListValue());
   any_array->Append(new base::FundamentalValue(1));
-  any_array->Append(base::Value::CreateStringValue("test"));
+  any_array->Append(new base::StringValue("test"));
   any_array->Append(CreateItemValue(2));
   params_value->Append(any_array.release());
   scoped_ptr<AnyArray::Params> params(
       AnyArray::Params::Create(*params_value));
   EXPECT_TRUE(params.get());
   ASSERT_EQ(3u, params->anys.size());
   int int_temp = 0;
   EXPECT_TRUE(params->anys[0]->GetAsInteger(&int_temp));
   EXPECT_EQ(1, int_temp);
 }
@@ skipping 54 matching lines @@
   base::ListValue* expected_argument = new base::ListValue();
   base::DictionaryValue* first = new base::DictionaryValue();
   first->SetInteger("val", 1);
   expected_argument->Append(first);
   base::DictionaryValue* second = new base::DictionaryValue();
   second->SetInteger("val", 2);
   expected_argument->Append(second);
   expected.Append(expected_argument);
   EXPECT_TRUE(results->Equals(&expected));
 }