chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

diff --git a/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc b/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

index ae70cbbad86e9c8fb8ef9988ca352832a57cf006..7484e7cc74fc5da5417ad4d1d0496e9630f6af75 100644

--- a/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

+++ b/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

@@ -290,7 +290,7 @@ TEST_F(ExtensionAppModelBuilderTest, InvalidOrdinal) {

scoped_prefs->UpdateExtensionPref(

kHostedAppId,

"page_ordinal",

- base::Value::CreateStringValue("a corrupted ordinal"));

+ new base::StringValue("a corrupted ordinal"));

// This should not assert or crash.

CreateBuilder();