Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: tools/json_schema_compiler/test/choices_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/choices_unittest.cc
diff --git a/tools/json_schema_compiler/test/choices_unittest.cc b/tools/json_schema_compiler/test/choices_unittest.cc
index 5253cd95f89f7a8d34686fc20d1fdf375a1f8f21..2cf1d8d358f79ef75ef79e168cbed8d8c95ef633 100644
--- a/tools/json_schema_compiler/test/choices_unittest.cc
+++ b/tools/json_schema_compiler/test/choices_unittest.cc
@@ -81,9 +81,9 @@ TEST(JsonSchemaCompilerChoicesTest, ObjectWithChoicesParamsCreateFail) {
{
scoped_ptr<base::DictionaryValue> object_param(new base::DictionaryValue());
object_param->SetWithoutPathExpansion("strings",
- base::Value::CreateStringValue("asdf"));
+ new base::StringValue("asdf"));
object_param->SetWithoutPathExpansion("integers",
- base::Value::CreateStringValue("asdf"));
+ new base::StringValue("asdf"));
scoped_ptr<base::ListValue> params_value(new base::ListValue());
params_value->Append(object_param.release());
scoped_ptr<ObjectWithChoices::Params> params(
@@ -109,7 +109,7 @@ TEST(JsonSchemaCompilerChoicesTest, PopulateChoiceType) {
base::ListValue* strings_value = new base::ListValue();
for (size_t i = 0; i < strings.size(); ++i)
- strings_value->Append(base::Value::CreateStringValue(strings[i]));
+ strings_value->Append(new base::StringValue(strings[i]));
base::DictionaryValue value;
value.SetInteger("integers", 4);
@@ -128,9 +128,9 @@ TEST(JsonSchemaCompilerChoicesTest, PopulateChoiceType) {
TEST(JsonSchemaCompilerChoicesTest, ChoiceTypeToValue) {
base::ListValue* strings_value = new base::ListValue();
- strings_value->Append(base::Value::CreateStringValue("list"));
- strings_value->Append(base::Value::CreateStringValue("of"));
- strings_value->Append(base::Value::CreateStringValue("strings"));
+ strings_value->Append(new base::StringValue("list"));
+ strings_value->Append(new base::StringValue("of"));
+ strings_value->Append(new base::StringValue("strings"));
base::DictionaryValue value;
value.SetInteger("integers", 5);
« no previous file with comments | « tools/json_schema_compiler/test/arrays_unittest.cc ('k') | tools/json_schema_compiler/test/crossref_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698