components/metrics/persisted_logs.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/persisted_logs.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/persisted_logs.cc

diff --git a/components/metrics/persisted_logs.cc b/components/metrics/persisted_logs.cc

index 17d6aa7dfd53754b9895f216bda9a5e7ad335fbf..7213b59806131c66868b7f4f651e1c1bd151c106 100644

--- a/components/metrics/persisted_logs.cc

+++ b/components/metrics/persisted_logs.cc

@@ -41,7 +41,7 @@ bool ReadBase64String(const base::ListValue& list_value,

void AppendBase64String(const std::string& str, base::ListValue* list_value) {

std::string base64_str;

base::Base64Encode(str, &base64_str);

- list_value->Append(base::Value::CreateStringValue(base64_str));

+ list_value->AppendString(base64_str);

}

} // namespace