extensions/browser/value_store/value_store_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/value_store/value_store_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/value_store/value_store_unittest.cc

diff --git a/extensions/browser/value_store/value_store_unittest.cc b/extensions/browser/value_store/value_store_unittest.cc

index a859570b6588ee7aef9b41fc46f79b3fc2de31da..4293459aa6752989ef5aaa534373a4c04561a5f5 100644

--- a/extensions/browser/value_store/value_store_unittest.cc

+++ b/extensions/browser/value_store/value_store_unittest.cc

@@ -135,9 +135,9 @@ ValueStoreTest::ValueStoreTest()

dict123_(new base::DictionaryValue()),

ui_thread_(BrowserThread::UI, base::MessageLoop::current()),

file_thread_(BrowserThread::FILE, base::MessageLoop::current()) {

- val1_.reset(base::Value::CreateStringValue(key1_ + "Value"));

- val2_.reset(base::Value::CreateStringValue(key2_ + "Value"));

- val3_.reset(base::Value::CreateStringValue(key3_ + "Value"));

+ val1_.reset(new base::StringValue(key1_ + "Value"));

+ val2_.reset(new base::StringValue(key2_ + "Value"));

+ val3_.reset(new base::StringValue(key3_ + "Value"));

list1_.push_back(key1_);

list2_.push_back(key2_);