chrome/browser/ui/webui/bidi_checker_web_ui_test.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

diff --git a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

index d08070751d3486668dce8dd284819dc783c21565..c218780ed791d22429432029fbabc0b7fd43f74c 100644

--- a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

+++ b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

@@ -102,7 +102,7 @@ void WebUIBidiCheckerBrowserTest::RunBidiCheckerOnPage(

const std::string& page_url, bool is_rtl) {

ui_test_utils::NavigateToURL(browser(), GURL(page_url));

ASSERT_TRUE(RunJavascriptTest("runBidiChecker",

- base::Value::CreateStringValue(page_url),

+ new base::StringValue(page_url),

new base::FundamentalValue(is_rtl)));

}