Get rid of the rest of CreateStringValue

extensions/browser/value_store/leveldb_value_store_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/value_store/value_store_unittest.h"
 
 #include "base/file_util.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
@@ skipping 48 matching lines @@
 
   content::TestBrowserThreadBundle thread_bundle_;
 };
 
 // Check that we can restore a single corrupted key in the LeveldbValueStore.
 TEST_F(LeveldbValueStoreUnitTest, RestoreKeyTest) {
   const char kNotCorruptKey[] = "not-corrupt";
   const char kValue[] = "value";
 
   // Insert a valid pair.
-  scoped_ptr<base::Value> value(base::Value::CreateStringValue(kValue));
+  scoped_ptr<base::Value> value(new base::StringValue(kValue));
   ASSERT_FALSE(
       store()->Set(ValueStore::DEFAULTS, kNotCorruptKey, *value)->HasError());
 
   // Insert a corrupt pair.
   const char kCorruptKey[] = "corrupt";
   leveldb::WriteBatch batch;
   batch.Put(kCorruptKey, "[{(.*+\"\'\\");
   ASSERT_TRUE(store()->WriteToDbForTest(&batch));
 
   // Verify corruption.
@@ skipping 20 matching lines @@
 // (unless absolutely necessary), and instead only removes corrupted keys.
 TEST_F(LeveldbValueStoreUnitTest, RestoreDoesMinimumNecessary) {
   const char* kNotCorruptKeys[] = {"a", "n", "z"};
   const size_t kNotCorruptKeysSize = 3u;
   const char kCorruptKey1[] = "f";
   const char kCorruptKey2[] = "s";
   const char kValue[] = "value";
   const char kCorruptValue[] = "[{(.*+\"\'\\";
 
   // Insert a collection of non-corrupted pairs.
-  scoped_ptr<base::Value> value(base::Value::CreateStringValue(kValue));
+  scoped_ptr<base::Value> value(new base::StringValue(kValue));
   for (size_t i = 0; i < kNotCorruptKeysSize; ++i) {
     ASSERT_FALSE(store()
                      ->Set(ValueStore::DEFAULTS, kNotCorruptKeys[i], *value)
                      ->HasError());
   }
 
   // Insert a few corrupted pairs.
   leveldb::WriteBatch batch;
   batch.Put(kCorruptKey1, kCorruptValue);
   batch.Put(kCorruptKey2, kCorruptValue);
@@ skipping 24 matching lines @@
 // Full corruption has been known to happen occasionally in strange edge cases,
 // such as after users use Windows Restore. We can't prevent it, but we need to
 // be able to handle it smoothly.
 TEST_F(LeveldbValueStoreUnitTest, RestoreFullDatabase) {
   const std::string kLolCats("I can haz leveldb filez?");
   const char* kNotCorruptKeys[] = {"a", "n", "z"};
   const size_t kNotCorruptKeysSize = 3u;
   const char kValue[] = "value";
 
   // Generate a database.
-  scoped_ptr<base::Value> value(base::Value::CreateStringValue(kValue));
+  scoped_ptr<base::Value> value(new base::StringValue(kValue));
   for (size_t i = 0; i < kNotCorruptKeysSize; ++i) {
     ASSERT_FALSE(store()
                      ->Set(ValueStore::DEFAULTS, kNotCorruptKeys[i], *value)
                      ->HasError());
   }
 
   // Close it (so we remove the lock), and replace all files with LolCats.
   CloseStore();
   base::FileEnumerator enumerator(
       database_path(), true /* recursive */, base::FileEnumerator::FILES);
   for (base::FilePath file = enumerator.Next(); !file.empty();
        file = enumerator.Next()) {
     // WriteFile() failure is a result of -1.
     ASSERT_NE(base::WriteFile(file, kLolCats.c_str(), kLolCats.length()),
               -1);
   }
   OpenStore();
 
   // We should definitely have an error.
   ValueStore::ReadResult result = store()->Get();
   ASSERT_TRUE(result->HasError());
   ASSERT_EQ(ValueStore::CORRUPTION, result->error().code);
 
   ASSERT_TRUE(store()->Restore());
   result = store()->Get();
   EXPECT_FALSE(result->HasError());
   // We couldn't recover anything, but we should be in a sane state again.
   EXPECT_EQ(0u, result->settings().size());
 }