Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/json_schema_compiler/test/arrays_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/arrays_unittest.cc
diff --git a/tools/json_schema_compiler/test/arrays_unittest.cc b/tools/json_schema_compiler/test/arrays_unittest.cc
index ea252440b8c2b2f444e65027352a14a510b83bfc..8d249b41c5d5cdcfdc62cc03f14321da9db49e35 100644
--- a/tools/json_schema_compiler/test/arrays_unittest.cc
+++ b/tools/json_schema_compiler/test/arrays_unittest.cc
@@ -15,10 +15,10 @@ namespace {
static scoped_ptr<base::DictionaryValue> CreateBasicArrayTypeDictionary() {
base::DictionaryValue* value = new base::DictionaryValue();
base::ListValue* strings_value = new base::ListValue();
- strings_value->Append(base::Value::CreateStringValue("a"));
- strings_value->Append(base::Value::CreateStringValue("b"));
- strings_value->Append(base::Value::CreateStringValue("c"));
- strings_value->Append(base::Value::CreateStringValue("it's easy as"));
+ strings_value->Append(new base::StringValue("a"));
+ strings_value->Append(new base::StringValue("b"));
+ strings_value->Append(new base::StringValue("c"));
+ strings_value->Append(new base::StringValue("it's easy as"));
base::ListValue* integers_value = new base::ListValue();
integers_value->Append(new base::FundamentalValue(1));
integers_value->Append(new base::FundamentalValue(2));
@@ -185,7 +185,7 @@ TEST(JsonSchemaCompilerArrayTest, OptionalEnumArrayType) {
{
base::DictionaryValue value;
scoped_ptr<base::ListValue> enum_array(new base::ListValue());
- enum_array->Append(base::Value::CreateStringValue("invalid"));
+ enum_array->Append(new base::StringValue("invalid"));
value.Set("types", enum_array.release());
OptionalEnumArrayType enum_array_type;
@@ -240,7 +240,7 @@ TEST(JsonSchemaCompilerArrayTest, AnyArrayParamsCreate) {
scoped_ptr<base::ListValue> params_value(new base::ListValue());
scoped_ptr<base::ListValue> any_array(new base::ListValue());
any_array->Append(new base::FundamentalValue(1));
- any_array->Append(base::Value::CreateStringValue("test"));
+ any_array->Append(new base::StringValue("test"));
any_array->Append(CreateItemValue(2));
params_value->Append(any_array.release());
scoped_ptr<AnyArray::Params> params(
« no previous file with comments | « tools/json_schema_compiler/test/any_unittest.cc ('k') | tools/json_schema_compiler/test/choices_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698