chromeos/network/onc/onc_translator_shill_to_onc.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translator_shill_to_onc.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translator_shill_to_onc.cc

diff --git a/chromeos/network/onc/onc_translator_shill_to_onc.cc b/chromeos/network/onc/onc_translator_shill_to_onc.cc

index 3c00e40ec1082881975849179530b5ecd8d9e761..a3651f6b16f4014e56d5f6cd3b2d3adcbd6cf74a 100644

--- a/chromeos/network/onc/onc_translator_shill_to_onc.cc

+++ b/chromeos/network/onc/onc_translator_shill_to_onc.cc

@@ -30,7 +30,7 @@ scoped_ptr<base::Value> ConvertStringToValue(const std::string& str,

base::Value::Type type) {

base::Value* value;

if (type == base::Value::TYPE_STRING) {

- value = base::Value::CreateStringValue(str);

+ value = new base::StringValue(str);

} else {

value = base::JSONReader::Read(str);

}