components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc ('k') | components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

diff --git a/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc b/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

index 2f8d1eaa3cbd269561b71c215cd1c7a62cd5cdb9..a49b76cf63e5b99b40079dd4a0e9686faecf7be7 100644

--- a/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

+++ b/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc

@@ -85,10 +85,16 @@ class ComponentCloudPolicyStoreTest : public testing::Test {

PolicyNamespace ns(POLICY_DOMAIN_EXTENSIONS, kTestExtension);

PolicyMap& policy = expected_bundle_.Get(ns);

- policy.Set("Name", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- base::Value::CreateStringValue("disabled"), NULL);

- policy.Set("Second", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER,

- base::Value::CreateStringValue("maybe"), NULL);

+ policy.Set("Name",

+ POLICY_LEVEL_MANDATORY,

+ POLICY_SCOPE_USER,

+ new base::StringValue("disabled"),

+ NULL);

+ policy.Set("Second",

+ POLICY_LEVEL_RECOMMENDED,

+ POLICY_SCOPE_USER,

+ new base::StringValue("maybe"),

+ NULL);

}

// Returns true if the policy exposed by the |store_| is empty.