chrome/renderer/chrome_content_renderer_client_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_content_renderer_client_unittest.cc

diff --git a/chrome/renderer/chrome_content_renderer_client_unittest.cc b/chrome/renderer/chrome_content_renderer_client_unittest.cc

index 48aa0fce32307ede42669ab497a8adb8dae6454e..6e6876c290c1f60956b597ab5f85908bf1934038 100644

--- a/chrome/renderer/chrome_content_renderer_client_unittest.cc

+++ b/chrome/renderer/chrome_content_renderer_client_unittest.cc

@@ -98,7 +98,7 @@ scoped_refptr<const extensions::Extension> CreateTestExtension(

manifest.SetInteger("manifest_version", 2);

if (is_hosted_app) {

base::ListValue* url_list = new base::ListValue();

- url_list->Append(base::Value::CreateStringValue(app_url));

+ url_list->Append(new base::StringValue(app_url));

manifest.Set(extensions::manifest_keys::kWebURLs, url_list);

manifest.SetString(extensions::manifest_keys::kLaunchWebURL, app_url);

}