chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/bidi_checker_web_ui_test.cc ('k') | chrome/browser/ui/webui/options/certificate_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

index a7c84aff5d34ee4c1c450ab82549d32905ccaae3..d0848799e5a4c6e261c1c19434d568679cff39b7 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

@@ -180,7 +180,7 @@ void NetInternalsTest::MessageHandler::GetTestServerURL(

std::string path;

ASSERT_TRUE(list_value->GetString(0, &path));

GURL url = net_internals_test_->test_server()->GetURL(path);

- scoped_ptr<base::Value> url_value(base::Value::CreateStringValue(url.spec()));

+ scoped_ptr<base::Value> url_value(new base::StringValue(url.spec()));

RunJavascriptCallback(url_value.get());

}