chrome/browser/extensions/extension_message_bubble_controller_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_gcm_app_handler_unittest.cc ('k') | chrome/browser/extensions/policy_handlers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

diff --git a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

index 5f206a085b4783e9e2514cf4749a704e49e9c10c..54fadcab64a3d66595bbdfed0579e4ff88114fb8 100644

--- a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

+++ b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

@@ -374,11 +374,10 @@ class ExtensionMessageBubbleTest : public testing::Test {

base::Time::Now(),

true, // is_enabled.

false); // is_incognito_enabled.

- extension_prefs_value_map->SetExtensionPref(

- id,

- prefs::kProxy,

- kExtensionPrefsScopeRegular,

- base::Value::CreateStringValue(id));

+ extension_prefs_value_map->SetExtensionPref(id,

+ prefs::kProxy,

+ kExtensionPrefsScopeRegular,

+ new base::StringValue(id));

if (ExtensionRegistry::Get(profile())->enabled_extensions().GetByID(id))

return testing::AssertionSuccess();