content/browser/tracing/etw_system_event_consumer_win.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/etw_system_event_consumer_win.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tracing/etw_system_event_consumer_win.cc

diff --git a/content/browser/tracing/etw_system_event_consumer_win.cc b/content/browser/tracing/etw_system_event_consumer_win.cc

index df20bce41d7a6aa1563e85ff439532ff1b1b6b74..fc3522fd81ecb2499bb792d717a20a0b43b7faa7 100644

--- a/content/browser/tracing/etw_system_event_consumer_win.cc

+++ b/content/browser/tracing/etw_system_event_consumer_win.cc

@@ -195,7 +195,7 @@ void EtwSystemEventConsumer::TraceAndConsumeOnThread() {

void EtwSystemEventConsumer::FlushOnThread(const OutputCallback& callback) {

// Add the header information to the stream.

scoped_ptr<base::DictionaryValue> header(new base::DictionaryValue());

- header->Set("name", base::Value::CreateStringValue("ETW"));

+ header->Set("name", new base::StringValue("ETW"));

// Release and pass the events buffer.

header->Set("content", events_.release());