Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: chromeos/network/network_configuration_handler_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/alert_commands.cc ('k') | chromeos/network/onc/onc_translator_onc_to_shill.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_configuration_handler_unittest.cc
diff --git a/chromeos/network/network_configuration_handler_unittest.cc b/chromeos/network/network_configuration_handler_unittest.cc
index e0161b65000b3407b15f06587a588ddbbc1b79c0..dcc47f0108f219e9cfbacde1c3b423d91eaf25c0 100644
--- a/chromeos/network/network_configuration_handler_unittest.cc
+++ b/chromeos/network/network_configuration_handler_unittest.cc
@@ -217,10 +217,10 @@ TEST_F(NetworkConfigurationHandlerTest, GetProperties) {
std::string networkName = "MyNetwork";
std::string key = "SSID";
scoped_ptr<base::StringValue> networkNameValue(
- base::Value::CreateStringValue(networkName));
+ new base::StringValue(networkName));
base::DictionaryValue value;
- value.Set(key, base::Value::CreateStringValue(networkName));
+ value.Set(key, new base::StringValue(networkName));
dictionary_value_result_ = &value;
EXPECT_CALL(*mock_service_client_,
SetProperty(dbus::ObjectPath(service_path), key,
@@ -251,10 +251,10 @@ TEST_F(NetworkConfigurationHandlerTest, SetProperties) {
std::string networkName = "MyNetwork";
std::string key = "SSID";
scoped_ptr<base::StringValue> networkNameValue(
- base::Value::CreateStringValue(networkName));
+ new base::StringValue(networkName));
base::DictionaryValue value;
- value.Set(key, base::Value::CreateStringValue(networkName));
+ value.Set(key, new base::StringValue(networkName));
dictionary_value_result_ = &value;
EXPECT_CALL(*mock_service_client_,
SetProperties(_, _, _, _)).WillOnce(
@@ -273,11 +273,11 @@ TEST_F(NetworkConfigurationHandlerTest, ClearProperties) {
std::string networkName = "MyNetwork";
std::string key = "SSID";
scoped_ptr<base::StringValue> networkNameValue(
- base::Value::CreateStringValue(networkName));
+ new base::StringValue(networkName));
// First set up a value to clear.
base::DictionaryValue value;
- value.Set(key, base::Value::CreateStringValue(networkName));
+ value.Set(key, new base::StringValue(networkName));
dictionary_value_result_ = &value;
EXPECT_CALL(*mock_service_client_,
SetProperties(_, _, _, _)).WillOnce(
@@ -310,11 +310,11 @@ TEST_F(NetworkConfigurationHandlerTest, ClearPropertiesError) {
std::string networkName = "MyNetwork";
std::string key = "SSID";
scoped_ptr<base::StringValue> networkNameValue(
- base::Value::CreateStringValue(networkName));
+ new base::StringValue(networkName));
// First set up a value to clear.
base::DictionaryValue value;
- value.Set(key, base::Value::CreateStringValue(networkName));
+ value.Set(key, new base::StringValue(networkName));
dictionary_value_result_ = &value;
EXPECT_CALL(*mock_service_client_,
SetProperties(_, _, _, _)).WillOnce(
@@ -351,9 +351,9 @@ TEST_F(NetworkConfigurationHandlerTest, CreateConfiguration) {
base::DictionaryValue value;
shill_property_util::SetSSID(networkName, &value);
value.SetWithoutPathExpansion(shill::kTypeProperty,
- base::Value::CreateStringValue(type));
+ new base::StringValue(type));
value.SetWithoutPathExpansion(shill::kProfileProperty,
- base::Value::CreateStringValue(profile));
+ new base::StringValue(profile));
EXPECT_CALL(*mock_manager_client_,
ConfigureServiceForProfile(dbus::ObjectPath(profile), _, _, _))
« no previous file with comments | « chrome/test/chromedriver/alert_commands.cc ('k') | chromeos/network/onc/onc_translator_onc_to_shill.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698