Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: components/url_matcher/url_matcher_factory_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/url_matcher/url_matcher_factory_unittest.cc
diff --git a/components/url_matcher/url_matcher_factory_unittest.cc b/components/url_matcher/url_matcher_factory_unittest.cc
index f789a3d078ea6d1519cbfa1104adcf3f99a4a0dd..e2871564d67edd8661792b0e8bc58294e87fd265 100644
--- a/components/url_matcher/url_matcher_factory_unittest.cc
+++ b/components/url_matcher/url_matcher_factory_unittest.cc
@@ -55,7 +55,7 @@ TEST(URLMatcherFactoryTest, CreateFromURLFilterDictionary) {
port_ranges->Append(port_range);
base::ListValue* scheme_list = new base::ListValue();
- scheme_list->Append(base::Value::CreateStringValue("http"));
+ scheme_list->Append(new base::StringValue("http"));
base::DictionaryValue valid_condition;
valid_condition.SetString(keys::kHostSuffixKey, "example.com");
@@ -137,7 +137,7 @@ TEST(URLMatcherFactoryTest, UpperCase) {
// {"scheme": ["HTTP"]}
base::ListValue* scheme_list = new base::ListValue();
- scheme_list->Append(base::Value::CreateStringValue("HTTP"));
+ scheme_list->Append(new base::StringValue("HTTP"));
base::DictionaryValue invalid_condition5;
invalid_condition5.Set(keys::kSchemesKey, scheme_list);
@@ -230,7 +230,7 @@ void UrlConditionCaseTest::CheckCondition(
base::DictionaryValue condition;
if (use_list_of_strings_) {
base::ListValue* list = new base::ListValue();
- list->Append(base::Value::CreateStringValue(value));
+ list->Append(new base::StringValue(value));
condition.SetWithoutPathExpansion(condition_key_, list);
} else {
condition.SetStringWithoutPathExpansion(condition_key_, value);

Powered by Google App Engine
This is Rietveld 408576698