chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/multiple_client_preferences_sync_test.cc ('k') | chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc b/chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc

index e544e8a183a1162cad2d5825d07310af0f66aaeb..85a22fac196eff1d59b0dc65f3b08122bb00c0f7 100644

--- a/chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc

+++ b/chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc

@@ -88,8 +88,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, ComplexPrefs) {

ASSERT_TRUE(AwaitIntegerPrefMatches(prefs::kRestoreOnStartup));

base::ListValue urls;

- urls.Append(base::Value::CreateStringValue("http://www.google.com/"));

- urls.Append(base::Value::CreateStringValue("http://www.flickr.com/"));

+ urls.Append(new base::StringValue("http://www.google.com/"));

+ urls.Append(new base::StringValue("http://www.flickr.com/"));

ChangeIntegerPref(0, prefs::kRestoreOnStartup, 4);

ChangeListPref(0, prefs::kURLsToRestoreOnStartup, urls);

ASSERT_TRUE(AwaitIntegerPrefMatches(prefs::kRestoreOnStartup));