components/policy/tools/generate_policy_source.py - Issue 388963002: Get rid of the rest of CreateStringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/tools/generate_policy_source.py

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/tools/generate_policy_source.py

diff --git a/components/policy/tools/generate_policy_source.py b/components/policy/tools/generate_policy_source.py

index c3957c7d906bcaf0084f9597ab09d33d6f0f1f1f..4e07baa70dbd6ed870dfa982ecc14ad883fe9237 100755

--- a/components/policy/tools/generate_policy_source.py

+++ b/components/policy/tools/generate_policy_source.py

@@ -825,7 +825,7 @@ base::ListValue* DecodeStringList(const em::StringList& string_list) {

RepeatedPtrField<std::string>::const_iterator entry;

for (entry = string_list.entries().begin();

entry != string_list.entries().end(); ++entry) {

- list_value->Append(base::Value::CreateStringValue(*entry));

+ list_value->AppendString(*entry);

}

return list_value;

}

@@ -860,7 +860,7 @@ def _CreateValue(type, arg):

elif type == 'TYPE_INTEGER':

return 'DecodeIntegerValue(%s)' % arg

elif type == 'TYPE_STRING':

- return 'base::Value::CreateStringValue(%s)' % arg

+ return 'new base::StringValue(%s)' % arg

elif type == 'TYPE_LIST':

return 'DecodeStringList(%s)' % arg

elif type == 'TYPE_DICTIONARY' or type == 'TYPE_EXTERNAL':