Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: athena/virtual_keyboard/virtual_keyboard_bindings_impl.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/resources/tile_priority.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/virtual_keyboard/virtual_keyboard_bindings_impl.cc
diff --git a/athena/virtual_keyboard/virtual_keyboard_bindings_impl.cc b/athena/virtual_keyboard/virtual_keyboard_bindings_impl.cc
index a04520c3dd46303c8a107cda36427dda6e81ad82..85fe5f52a125d9bd7595834c6d35eb5b1f43e018 100644
--- a/athena/virtual_keyboard/virtual_keyboard_bindings_impl.cc
+++ b/athena/virtual_keyboard/virtual_keyboard_bindings_impl.cc
@@ -143,11 +143,11 @@ class VKBindings : public gin::Wrappable<VKBindings> {
return;
}
base::ListValue params;
- params.Set(0, base::Value::CreateStringValue(event.event_type));
- params.Set(1, base::Value::CreateIntegerValue(event.char_value));
- params.Set(2, base::Value::CreateIntegerValue(event.key_code));
- params.Set(3, base::Value::CreateStringValue(event.key_name));
- params.Set(4, base::Value::CreateIntegerValue(event.modifiers));
+ params.Set(0, new base::StringValue(event.event_type));
+ params.Set(1, new base::FundamentalValue(event.char_value));
+ params.Set(2, new base::FundamentalValue(event.key_code));
+ params.Set(3, new base::StringValue(event.key_name));
+ params.Set(4, new base::FundamentalValue(event.modifiers));
std::string params_json;
JSONStringValueSerializer serializer(&params_json);
« no previous file with comments | « no previous file | cc/resources/tile_priority.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698