components/policy/core/common/policy_loader_mac_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/policy/core/common/policy_loader_mac_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <CoreFoundation/CoreFoundation.h>	5 #include <CoreFoundation/CoreFoundation.h>

6	6

7 #include "base/basictypes.h"	7 #include "base/basictypes.h"

8 #include "base/callback.h"	8 #include "base/callback.h"

9 #include "base/files/file_path.h"	9 #include "base/files/file_path.h"

10 #include "base/mac/scoped_cftyperef.h"	10 #include "base/mac/scoped_cftyperef.h"

(...skipping 174 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
185 prefs_->AddTestItem(name, test_value.get(), false);	185 prefs_->AddTestItem(name, test_value.get(), false);

186	186

187 // Make the provider read the updated \|prefs_\|.	187 // Make the provider read the updated \|prefs_\|.

188 provider_->RefreshPolicies();	188 provider_->RefreshPolicies();

189 loop_.RunUntilIdle();	189 loop_.RunUntilIdle();

190 PolicyBundle expected_bundle;	190 PolicyBundle expected_bundle;

191 expected_bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))	191 expected_bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))

192 .Set(test_keys::kKeyString,	192 .Set(test_keys::kKeyString,

193 POLICY_LEVEL_RECOMMENDED,	193 POLICY_LEVEL_RECOMMENDED,

194 POLICY_SCOPE_USER,	194 POLICY_SCOPE_USER,

195 base::Value::CreateStringValue("string value"),	195 new base::StringValue("string value"),

196 NULL);	196 NULL);

197 EXPECT_TRUE(provider_->policies().Equals(expected_bundle));	197 EXPECT_TRUE(provider_->policies().Equals(expected_bundle));

198 }	198 }

199	199

200 } // namespace policy	200 } // namespace policy

OLD	NEW