chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc - Issue 388963002: Get rid of the rest of CreateStringValue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 388963002: Get rid of the rest of CreateStringValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prefs/session_startup_pref_unittest.cc ('k') | chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

index 8a0aa91939a0e908ad101bda14caf5c8c8144297..0d323bbce6a5365703e8dc9e985d498e9fb3a79a 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

@@ -241,9 +241,9 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabled) {

MockServiceProcessControl::kServiceStateDisabled, false);

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

- prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(

- MockServiceProcessControl::EnabledUserId()));

+ prefs->SetUserPref(

+ prefs::kCloudPrintEmail,

+ new base::StringValue(MockServiceProcessControl::EnabledUserId()));

service.Initialize();

@@ -258,7 +258,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabled) {

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(std::string()));

+ new base::StringValue(std::string()));

service.Initialize();

service.RefreshStatusFromService();

@@ -275,7 +275,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyDisabled) {

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(std::string()));

+ new base::StringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

new base::FundamentalValue(false));

@@ -293,7 +293,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyEnabled) {

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(std::string()));

+ new base::StringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

new base::FundamentalValue(false));

@@ -309,9 +309,9 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenSetPolicy) {

MockServiceProcessControl::kServiceStateDisabled, false);

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

- prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(

- MockServiceProcessControl::EnabledUserId()));

+ prefs->SetUserPref(

+ prefs::kCloudPrintEmail,

+ new base::StringValue(MockServiceProcessControl::EnabledUserId()));

service.Initialize();

@@ -331,7 +331,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabledThenSetPolicy) {

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(std::string()));

+ new base::StringValue(std::string()));

service.Initialize();

service.RefreshStatusFromService();

@@ -355,7 +355,7 @@ TEST_F(CloudPrintProxyPolicyTest,

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(std::string()));

+ new base::StringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

new base::FundamentalValue(false));

@@ -376,7 +376,7 @@ TEST_F(CloudPrintProxyPolicyTest,

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(std::string()));

+ new base::StringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

new base::FundamentalValue(false));

@@ -394,9 +394,9 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenEnable) {

MockServiceProcessControl::kServiceStateDisabled, false);

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

- prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(

- MockServiceProcessControl::EnabledUserId()));

+ prefs->SetUserPref(

+ prefs::kCloudPrintEmail,

+ new base::StringValue(MockServiceProcessControl::EnabledUserId()));

service.Initialize();

EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));

@@ -418,7 +418,7 @@ TEST_F(CloudPrintProxyPolicyTest,

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(std::string()));

+ new base::StringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

new base::FundamentalValue(false));

@@ -454,7 +454,7 @@ KeyedService* TestCloudPrintProxyServiceFactory(

TEST_F(CloudPrintProxyPolicyTest, StartupBrowserCreatorWithCommandLine) {

TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

- base::Value::CreateStringValue(std::string()));

+ new base::StringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

new base::FundamentalValue(false));