Get rid of the rest of CreateStringValue

components/pref_registry/pref_registry_syncable.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/pref_registry/pref_registry_syncable.h"
 
 #include "base/files/file_path.h"
 #include "base/prefs/default_pref_store.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
@@ skipping 26 matching lines @@
       return new base::FundamentalValue(val);
     }
 
     case base::Value::TYPE_DOUBLE: {
       double val;
       base::StringToDouble(resource_string, &val);
       return base::Value::CreateDoubleValue(val);
     }
 
     case base::Value::TYPE_STRING: {
-      return base::Value::CreateStringValue(resource_string);
+      return new base::StringValue(resource_string);
     }
 
     default: {
       NOTREACHED() <<
           "list and dictionary types cannot have default locale values";
     }
   }
   NOTREACHED();
   return base::Value::CreateNullValue();
 }
@@ skipping 34 matching lines @@
                                               double default_value,
                                               PrefSyncStatus sync_status) {
   RegisterSyncablePreference(path,
                              base::Value::CreateDoubleValue(default_value),
                              sync_status);
 }
 
 void PrefRegistrySyncable::RegisterStringPref(const char* path,
                                               const std::string& default_value,
                                               PrefSyncStatus sync_status) {
-  RegisterSyncablePreference(path,
-                             base::Value::CreateStringValue(default_value),
-                             sync_status);
+  RegisterSyncablePreference(
+      path, new base::StringValue(default_value), sync_status);
 }
 
 void PrefRegistrySyncable::RegisterFilePathPref(
     const char* path,
     const base::FilePath& default_value,
     PrefSyncStatus sync_status) {
-  RegisterSyncablePreference(path,
-                             base::Value::CreateStringValue(
-                                 default_value.value()),
-                             sync_status);
+  RegisterSyncablePreference(
+      path, new base::StringValue(default_value.value()), sync_status);
 }
 
 void PrefRegistrySyncable::RegisterListPref(const char* path,
                                             PrefSyncStatus sync_status) {
   RegisterSyncablePreference(path, new base::ListValue(), sync_status);
 }
 
 void PrefRegistrySyncable::RegisterListPref(const char* path,
                                             base::ListValue* default_value,
                                             PrefSyncStatus sync_status) {
@@ skipping 55 matching lines @@
                                locale_default_message_id),
       sync_status);
 }
 
 void PrefRegistrySyncable::RegisterInt64Pref(
     const char* path,
     int64 default_value,
     PrefSyncStatus sync_status) {
   RegisterSyncablePreference(
       path,
-      base::Value::CreateStringValue(base::Int64ToString(default_value)),
+      new base::StringValue(base::Int64ToString(default_value)),
       sync_status);
 }
 
 void PrefRegistrySyncable::RegisterUint64Pref(
     const char* path,
     uint64 default_value,
     PrefSyncStatus sync_status) {
   RegisterSyncablePreference(
       path,
-      base::Value::CreateStringValue(base::Uint64ToString(default_value)),
+      new base::StringValue(base::Uint64ToString(default_value)),
       sync_status);
 }
 
 void PrefRegistrySyncable::RegisterSyncablePreference(
     const char* path,
     base::Value* default_value,
     PrefSyncStatus sync_status) {
   PrefRegistry::RegisterPreference(path, default_value);
 
   if (sync_status == PrefRegistrySyncable::SYNCABLE_PREF ||
       sync_status == PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF) {
     syncable_preferences_[path] = sync_status;
 
     if (!callback_.is_null())
       callback_.Run(path, sync_status);
   }
 }
 
 scoped_refptr<PrefRegistrySyncable> PrefRegistrySyncable::ForkForIncognito() {
   // TODO(joi): We can directly reuse the same PrefRegistry once
   // PrefService no longer registers for callbacks on registration and
   // unregistration.
   scoped_refptr<PrefRegistrySyncable> registry(new PrefRegistrySyncable());
   registry->defaults_ = defaults_;
   return registry;
 }
 
 }  // namespace user_prefs