Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Created:
3 years, 7 months ago by jdoerrie
Modified:
3 years, 6 months ago
Reviewers:
vabr (Chromium), brettw
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, Peter Beverloo, zea+watch_chromium.org, vmpstr+watch_chromium.org, rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, khorimoto+watch-tether_chromium.org, browser-components-watch_chromium.org, hansberry+watch-tether_chromium.org, mathp+autofillwatch_chromium.org, jhawkins+watch-tether_chromium.org, tengs+watch-tether_chromium.org, rogerm+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, danakj+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, johnme+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove raw DictionaryValue::Set in //components This change removes the deprecated raw pointer version of base::DictionaryValue::Set in //components and replaces it with the unique pointer version or other convenience functions where appropriate. BUG=646113, 581865 Review-Url: https://codereview.chromium.org/2889163002 Cr-Commit-Position: refs/heads/master@{#476609} Committed: https://chromium.googlesource.com/chromium/src/+/c1a515dfc10c025e5406f19b51f47ecba5496f5b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ExpectStringValue #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -346 lines) Patch
M base/test/values_test_util.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/test/values_test_util.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_address_util.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_codec.h View 2 chunks +11 lines, -11 lines 0 comments Download
M components/bookmarks/browser/bookmark_codec.cc View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M components/cloud_devices/common/cloud_device_description.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M components/cloud_devices/common/printer_description.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/domain_reliability/beacon.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/domain_reliability/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/error_page/common/localized_error.cc View 7 chunks +16 lines, -14 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/error_page/renderer/net_error_helper_core_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/flags_ui/flags_state.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M components/gcm_driver/gcm_internals_helper.cc View 3 chunks +22 lines, -20 lines 0 comments Download
M components/history/core/browser/web_history_service.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/invalidation/impl/p2p_invalidator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/sync_invalidation_listener.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/unacked_invalidation_set.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/invalidation/public/invalidation.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/json_schema/json_schema_validator_unittest_base.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/login/screens/screen_context.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M components/physical_web/webui/physical_web_base_message_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/policy/core/common/config_dir_policy_loader_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/policy/core/common/configuration_policy_provider_test.cc View 1 3 chunks +19 lines, -18 lines 0 comments Download
M components/policy/core/common/schema_unittest.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/screenlock_bridge.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M components/search_engines/default_search_manager_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M components/search_engines/default_search_policy_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/search_engines/template_url_prepopulate_data_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/signin/core/browser/about_signin_internals.cc View 7 chunks +23 lines, -27 lines 0 comments Download
M components/sync/base/model_type.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M components/sync/driver/about_sync_util.cc View 1 2 13 chunks +33 lines, -29 lines 0 comments Download
M components/sync/engine/cycle/sync_cycle_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/events/protocol_event.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine_impl/js_mutation_event_observer.cc View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M components/sync/engine_impl/js_mutation_event_observer_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/sync/engine_impl/js_sync_encryption_handler_observer_unittest.cc View 1 2 3 3 chunks +10 lines, -6 lines 0 comments Download
M components/sync/js/js_event_details_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/sync/protocol/sync_protocol_error.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/protocol/sync_protocol_error.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/sync/syncable/base_node.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/base_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/entry.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sync/syncable/entry.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/sync/syncable/entry_kernel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/syncable/entry_kernel.cc View 6 chunks +38 lines, -36 lines 0 comments Download
M components/sync/syncable/model_type.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M components/sync/syncable/model_type_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/syncable/syncable_id.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync/syncable/syncable_id.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/syncable/syncable_id_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/syncable/write_transaction_info.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sync/syncable/write_transaction_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/test/fake_server/fake_server.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_wifi/wifi_credential.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M components/url_matcher/url_matcher_factory_unittest.cc View 1 2 3 chunks +9 lines, -8 lines 0 comments Download
M components/webcrypto/algorithms/aes_cbc_unittest.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M components/webcrypto/algorithms/aes_kw_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/webcrypto/algorithms/hmac_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M components/webcrypto/jwk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (22 generated)
jdoerrie
vabr@chromium.org: Please review the whole CL in detail. brettw@chromium.org: Please spot-check and rubber-stamp.
3 years, 7 months ago (2017-05-18 14:12:29 UTC) #7
brettw
https://codereview.chromium.org/2889163002/diff/1/base/test/values_test_util.h File base/test/values_test_util.h (right): https://codereview.chromium.org/2889163002/diff/1/base/test/values_test_util.h#newcode42 base/test/values_test_util.h:42: std::unique_ptr<Value> actual); It seems weird to me that such ...
3 years, 7 months ago (2017-05-19 20:31:03 UTC) #8
jdoerrie
https://codereview.chromium.org/2889163002/diff/1/base/test/values_test_util.h File base/test/values_test_util.h (right): https://codereview.chromium.org/2889163002/diff/1/base/test/values_test_util.h#newcode42 base/test/values_test_util.h:42: std::unique_ptr<Value> actual); On 2017/05/19 20:31:02, brettw wrote: > It ...
3 years, 7 months ago (2017-05-22 08:16:00 UTC) #11
brettw
Looks nice now, thanks! LGTM
3 years, 7 months ago (2017-05-22 20:03:29 UTC) #14
vabr (Chromium)
LGTM, thanks for cleaning all of this up! Vaclav https://codereview.chromium.org/2889163002/diff/40001/components/sync/base/model_type.h File components/sync/base/model_type.h (right): https://codereview.chromium.org/2889163002/diff/40001/components/sync/base/model_type.h#newcode288 components/sync/base/model_type.h:288: ...
3 years, 6 months ago (2017-06-01 19:53:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889163002/60001
3 years, 6 months ago (2017-06-02 09:39:48 UTC) #26
jdoerrie
Thanks, Vaclav! https://codereview.chromium.org/2889163002/diff/40001/components/sync/base/model_type.h File components/sync/base/model_type.h (right): https://codereview.chromium.org/2889163002/diff/40001/components/sync/base/model_type.h#newcode288 components/sync/base/model_type.h:288: // On 2017/06/01 19:53:33, vabr (hobby-only until ...
3 years, 6 months ago (2017-06-02 09:39:56 UTC) #27
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 09:44:53 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c1a515dfc10c025e5406f19b51f4...

Powered by Google App Engine
This is Rietveld 408576698