Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: components/sync/syncable/write_transaction_info.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/syncable/write_transaction_info.h
diff --git a/components/sync/syncable/write_transaction_info.h b/components/sync/syncable/write_transaction_info.h
index f4d7b0dd78f89ff9eeb8f67559653b782f8e728d..cf385cbb525c59519f008fb10eb7654909cefbe9 100644
--- a/components/sync/syncable/write_transaction_info.h
+++ b/components/sync/syncable/write_transaction_info.h
@@ -8,8 +8,10 @@
#include <stddef.h>
#include <stdint.h>
+#include <memory>
#include <string>
+#include "base/values.h"
#include "components/sync/syncable/entry_kernel.h"
#include "components/sync/syncable/syncable_base_transaction.h"
@@ -26,8 +28,8 @@ struct WriteTransactionInfo {
WriteTransactionInfo(const WriteTransactionInfo& other);
~WriteTransactionInfo();
- // Caller owns the return value.
- base::DictionaryValue* ToValue(size_t max_mutations_size) const;
+ std::unique_ptr<base::DictionaryValue> ToValue(
+ size_t max_mutations_size) const;
int64_t id;
// If tracked_objects::Location becomes assignable, we can use that
« no previous file with comments | « components/sync/syncable/syncable_id_unittest.cc ('k') | components/sync/syncable/write_transaction_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698