Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/cloud_devices/common/cloud_device_description.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cloud_devices/common/cloud_device_description.cc
diff --git a/components/cloud_devices/common/cloud_device_description.cc b/components/cloud_devices/common/cloud_device_description.cc
index 56cbb463bcc996993515a1ce18f6bf6170634eb6..75518b22ccc6f2302ec3901648651e7f71ddaafb 100644
--- a/components/cloud_devices/common/cloud_device_description.cc
+++ b/components/cloud_devices/common/cloud_device_description.cc
@@ -63,9 +63,7 @@ const base::DictionaryValue* CloudDeviceDescription::GetItem(
base::DictionaryValue* CloudDeviceDescription::CreateItem(
const std::string& path) {
- base::DictionaryValue* value = new base::DictionaryValue;
- root_->Set(path, value);
- return value;
+ return root_->SetDictionary(path, base::MakeUnique<base::DictionaryValue>());
}
const base::ListValue* CloudDeviceDescription::GetListItem(
@@ -77,9 +75,7 @@ const base::ListValue* CloudDeviceDescription::GetListItem(
base::ListValue* CloudDeviceDescription::CreateListItem(
const std::string& path) {
- base::ListValue* value = new base::ListValue;
- root_->Set(path, value);
- return value;
+ return root_->SetList(path, base::MakeUnique<base::ListValue>());
}
} // namespace cloud_devices
« no previous file with comments | « components/bookmarks/browser/bookmark_codec.cc ('k') | components/cloud_devices/common/printer_description.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698