Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: components/json_schema/json_schema_validator_unittest_base.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/invalidation/public/invalidation.cc ('k') | components/login/screens/screen_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/json_schema/json_schema_validator_unittest_base.cc
diff --git a/components/json_schema/json_schema_validator_unittest_base.cc b/components/json_schema/json_schema_validator_unittest_base.cc
index d49bb0679c3f9f0b27a5634a119a9d42e6aab63c..2b03abe613477d92c4d480e02bee7aa25c09595d 100644
--- a/components/json_schema/json_schema_validator_unittest_base.cc
+++ b/components/json_schema/json_schema_validator_unittest_base.cc
@@ -255,9 +255,9 @@ void JSONSchemaValidatorTestBase::TestObject() {
schema->Remove(schema::kPatternProperties, NULL);
// Test additional properties.
- base::DictionaryValue* additional_properties = new base::DictionaryValue();
+ base::DictionaryValue* additional_properties = schema->SetDictionary(
+ schema::kAdditionalProperties, base::MakeUnique<base::DictionaryValue>());
additional_properties->SetString(schema::kType, schema::kAny);
- schema->Set(schema::kAdditionalProperties, additional_properties);
instance->SetBoolean("extra", true);
ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
@@ -406,9 +406,9 @@ void JSONSchemaValidatorTestBase::TestArrayTuple() {
schema::kString,
schema::kInteger));
- base::DictionaryValue* additional_properties = new base::DictionaryValue();
+ base::DictionaryValue* additional_properties = schema->SetDictionary(
+ schema::kAdditionalProperties, base::MakeUnique<base::DictionaryValue>());
additional_properties->SetString(schema::kType, schema::kAny);
- schema->Set(schema::kAdditionalProperties, additional_properties);
instance->Set(0, base::MakeUnique<base::Value>("42"));
instance->AppendString("anything");
ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
« no previous file with comments | « components/invalidation/public/invalidation.cc ('k') | components/login/screens/screen_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698