Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: components/sync/syncable/entry_kernel.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/syncable/entry.cc ('k') | components/sync/syncable/entry_kernel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/syncable/entry_kernel.h
diff --git a/components/sync/syncable/entry_kernel.h b/components/sync/syncable/entry_kernel.h
index 2be38b63eefba83c1a0fcfe43f4a7c37794c9872..fa57de93e3e7111b077dcb95cd3a9dc666d5be75 100644
--- a/components/sync/syncable/entry_kernel.h
+++ b/components/sync/syncable/entry_kernel.h
@@ -372,11 +372,11 @@ struct EntryKernel {
bool ShouldMaintainHierarchy() const;
// Dumps all kernel info into a DictionaryValue and returns it.
- // Transfers ownership of the DictionaryValue to the caller.
// Note: |cryptographer| is an optional parameter for use in decrypting
// encrypted specifics. If it is null or the specifics are not decryptsble,
// they will be serialized as empty proto's.
- base::DictionaryValue* ToValue(Cryptographer* cryptographer) const;
+ std::unique_ptr<base::DictionaryValue> ToValue(
+ Cryptographer* cryptographer) const;
size_t EstimateMemoryUsage() const;
« no previous file with comments | « components/sync/syncable/entry.cc ('k') | components/sync/syncable/entry_kernel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698