components/sync/syncable/syncable_id.h - Issue 2889163002: Remove raw DictionaryValue::Set in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/syncable/syncable_id.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Patch Set: Nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/syncable/syncable_id.h

diff --git a/components/sync/syncable/syncable_id.h b/components/sync/syncable/syncable_id.h

index 100244b07267d7454a0cf09c3046883814aafb21..67cf909ec9d6b64913b24c708522c0efa72fc157 100644

--- a/components/sync/syncable/syncable_id.h

+++ b/components/sync/syncable/syncable_id.h

@@ -69,9 +69,8 @@ class Id {

// by operator<.

Id GetLexicographicSuccessor() const;

- // Dumps the ID as a value and returns it. Transfers ownership of

- // the StringValue to the caller.

- base::Value* ToValue() const;

+ // Dumps the ID as a value and returns it.

+ std::unique_ptr<base::Value> ToValue() const;

// Three functions are used to work with our proto buffers.

std::string GetServerId() const;