Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: components/autofill/core/browser/autofill_address_util.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.cc ('k') | components/bookmarks/browser/bookmark_codec.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_address_util.cc
diff --git a/components/autofill/core/browser/autofill_address_util.cc b/components/autofill/core/browser/autofill_address_util.cc
index bdeea813bf58d445c2dd92811d10ee2ee019a665..e5d9872d18de763bea615b970f1dcc51fbb3ea4a 100644
--- a/components/autofill/core/browser/autofill_address_util.cc
+++ b/components/autofill/core/browser/autofill_address_util.cc
@@ -171,7 +171,7 @@ void SetCountryData(const PersonalDataManager& manager,
"value", countries[i] ? countries[i]->country_code() : "separator");
country_list->Append(std::move(option_details));
}
- localized_strings->Set("autofillCountrySelectList", country_list.release());
+ localized_strings->Set("autofillCountrySelectList", std::move(country_list));
std::unique_ptr<base::ListValue> default_country_components(
new base::ListValue);
@@ -180,7 +180,7 @@ void SetCountryData(const PersonalDataManager& manager,
default_country_components.get(),
&default_country_language_code);
localized_strings->Set("autofillDefaultCountryComponents",
- default_country_components.release());
+ std::move(default_country_components));
localized_strings->SetString("autofillDefaultCountryLanguageCode",
default_country_language_code);
}
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.cc ('k') | components/bookmarks/browser/bookmark_codec.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698