Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: components/sync_wifi/wifi_credential.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_wifi/wifi_credential.cc
diff --git a/components/sync_wifi/wifi_credential.cc b/components/sync_wifi/wifi_credential.cc
index 0337ee8188f30e420dbe0a5118c3a929e86feeed..bf6294a3f272e67bf0f03b37c3872add32159bac 100644
--- a/components/sync_wifi/wifi_credential.cc
+++ b/components/sync_wifi/wifi_credential.cc
@@ -52,20 +52,19 @@ std::unique_ptr<base::DictionaryValue> WifiCredential::ToOncProperties() const {
return base::MakeUnique<base::DictionaryValue>();
}
- std::unique_ptr<base::DictionaryValue> onc_properties(
- new base::DictionaryValue());
- onc_properties->Set(onc::toplevel_config::kType,
- new base::Value(onc::network_type::kWiFi));
+ auto onc_properties = base::MakeUnique<base::DictionaryValue>();
+ onc_properties->SetString(onc::toplevel_config::kType,
+ onc::network_type::kWiFi);
// TODO(quiche): Switch to the HexSSID property, once ONC fully supports it.
// crbug.com/432546.
- onc_properties->Set(onc::network_config::WifiProperty(onc::wifi::kSSID),
- new base::Value(ssid_utf8));
- onc_properties->Set(onc::network_config::WifiProperty(onc::wifi::kSecurity),
- new base::Value(onc_security));
+ onc_properties->SetString(onc::network_config::WifiProperty(onc::wifi::kSSID),
+ ssid_utf8);
+ onc_properties->SetString(
+ onc::network_config::WifiProperty(onc::wifi::kSecurity), onc_security);
if (WifiSecurityClassSupportsPassphrases(security_class())) {
- onc_properties->Set(
+ onc_properties->SetString(
onc::network_config::WifiProperty(onc::wifi::kPassphrase),
- new base::Value(passphrase()));
+ passphrase());
}
return onc_properties;
}
« no previous file with comments | « components/sync/test/fake_server/fake_server.cc ('k') | components/url_matcher/url_matcher_factory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698