Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: components/domain_reliability/beacon.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/beacon.cc
diff --git a/components/domain_reliability/beacon.cc b/components/domain_reliability/beacon.cc
index 8a8a549f8c2ca44573714dfac7fb0d5020fe2f0c..590a666eaad12eb169096c57b22965fb8baa8488 100644
--- a/components/domain_reliability/beacon.cc
+++ b/components/domain_reliability/beacon.cc
@@ -6,6 +6,7 @@
#include <utility>
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "components/domain_reliability/util.h"
#include "net/base/net_errors.h"
@@ -25,7 +26,7 @@ std::unique_ptr<Value> DomainReliabilityBeacon::ToValue(
base::TimeTicks last_network_change_time,
const GURL& collector_url,
const std::vector<std::unique_ptr<std::string>>& path_prefixes) const {
- std::unique_ptr<DictionaryValue> beacon_value(new DictionaryValue());
+ auto beacon_value = base::MakeUnique<DictionaryValue>();
DCHECK(url.is_valid());
GURL sanitized_url = SanitizeURLForReport(url, collector_url, path_prefixes);
beacon_value->SetString("url", sanitized_url.spec());
@@ -33,10 +34,10 @@ std::unique_ptr<Value> DomainReliabilityBeacon::ToValue(
if (!quic_error.empty())
beacon_value->SetString("quic_error", quic_error);
if (chrome_error != net::OK) {
- DictionaryValue* failure_value = new DictionaryValue();
+ auto failure_value = base::MakeUnique<DictionaryValue>();
failure_value->SetString("custom_error",
net::ErrorToString(chrome_error));
- beacon_value->Set("failure_data", failure_value);
+ beacon_value->Set("failure_data", std::move(failure_value));
}
beacon_value->SetString("server_ip", server_ip);
beacon_value->SetBoolean("was_proxied", was_proxied);

Powered by Google App Engine
This is Rietveld 408576698