components/sync/syncable/base_node.cc - Issue 2889163002: Remove raw DictionaryValue::Set in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/syncable/base_node.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)

Patch Set: Nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/syncable/base_node.cc

diff --git a/components/sync/syncable/base_node.cc b/components/sync/syncable/base_node.cc

index 58096c30a1b3717fc0bbc7ad552e23e638dcc098..9e64f49541a01a23ea331ce546b93cf224db2b5e 100644

--- a/components/sync/syncable/base_node.cc

+++ b/components/sync/syncable/base_node.cc

@@ -217,7 +217,7 @@ int BaseNode::GetPositionIndex() const {

return GetEntry()->GetPositionIndex();

}

-base::DictionaryValue* BaseNode::ToValue() const {

+std::unique_ptr<base::DictionaryValue> BaseNode::ToValue() const {

return GetEntry()->ToValue(GetTransaction()->GetCryptographer());

}

« no previous file with comments | « components/sync/syncable/base_node.h ('k') | components/sync/syncable/entry.h » ('j') | no next file with comments »