Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: components/sync/js/js_event_details_unittest.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/js/js_event_details_unittest.cc
diff --git a/components/sync/js/js_event_details_unittest.cc b/components/sync/js/js_event_details_unittest.cc
index 4b56e7d518f64c53a947a8667fe2e2b8f46127a1..d20cd0d546326c69a288c4395bb75b642cd9e905 100644
--- a/components/sync/js/js_event_details_unittest.cc
+++ b/components/sync/js/js_event_details_unittest.cc
@@ -5,7 +5,10 @@
#include "components/sync/js/js_event_details.h"
#include <memory>
+#include <utility>
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace syncer {
@@ -22,9 +25,9 @@ TEST_F(JsEventDetailsTest, EmptyList) {
TEST_F(JsEventDetailsTest, FromDictionary) {
base::DictionaryValue dict;
dict.SetString("foo", "bar");
- dict.Set("baz", new base::ListValue());
+ dict.Set("baz", base::MakeUnique<base::ListValue>());
- std::unique_ptr<base::DictionaryValue> dict_copy(dict.DeepCopy());
+ auto dict_copy = base::MakeUnique<base::DictionaryValue>(dict);
JsEventDetails details(&dict);

Powered by Google App Engine
This is Rietveld 408576698